From 7888ccb7e6c00463e8fd00de7c888ebbd1c75e54 Mon Sep 17 00:00:00 2001
From: TheOnlyMace <0815cracky@gmail.com>
Date: Wed, 22 Jul 2026 21:34:29 +0200
Subject: [PATCH] Refactor leveling form to use Discord multiplier editor and
 enhance localization

- Replaced text area inputs for role and channel multipliers with DiscordMultiplierEditor components for improved user experience.
- Updated state management to handle multiplier entries as objects instead of text, enhancing data integrity.
- Enhanced localization messages for multipliers, including error handling and hints for user guidance.
---
 .../src/components/modules/leveling-form.tsx  |  87 ++++++-------
 .../components/modules/ticket-config-form.tsx |   4 +-
 .../ui/discord-multiplier-editor.tsx          | 122 ++++++++++++++++++
 apps/webui/src/messages/de.json               |  27 ++--
 apps/webui/src/messages/en.json               |  27 ++--
 5 files changed, 198 insertions(+), 69 deletions(-)
 create mode 100644 apps/webui/src/components/ui/discord-multiplier-editor.tsx

diff --git a/apps/webui/src/components/modules/leveling-form.tsx b/apps/webui/src/components/modules/leveling-form.tsx
index 3aab9a2..885f4e0 100644
--- a/apps/webui/src/components/modules/leveling-form.tsx
+++ b/apps/webui/src/components/modules/leveling-form.tsx
@@ -5,6 +5,12 @@ import { FieldAnchor } from '@/components/layout/field-anchor';
 import { useTranslations } from '@/components/locale-provider';
 import { Card, CardContent, CardDescription, CardHeader, CardTitle } from '@/components/ui/card';
 import { DiscordChannelMultiSelect, DiscordChannelSelect } from '@/components/ui/discord-channel-select';
+import {
+  DiscordMultiplierEditor,
+  mapToMultiplierEntries,
+  multiplierEntriesToMap,
+  type MultiplierEntry
+} from '@/components/ui/discord-multiplier-editor';
 import { DiscordRoleMultiSelect } from '@/components/ui/discord-role-select';
 import { Input } from '@/components/ui/input';
 import { Label } from '@/components/ui/label';
@@ -16,55 +22,34 @@ import { SettingsForm } from '@/components/settings/settings-form';
 
 interface LocalLevelingValue
   extends Omit<LevelingConfigDashboard, 'roleMultipliers' | 'channelMultipliers'> {
-  roleMultipliersText: string;
-  channelMultipliersText: string;
-}
-
-function toMultiplierText(map: Record<string, number>): string {
-  return Object.entries(map)
-    .map(([id, multiplier]) => `${id}:${multiplier}`)
-    .join('\n');
-}
-
-function fromMultiplierText(text: string): { value: Record<string, number>; error?: string } {
-  const value: Record<string, number> = {};
-  const lines = text
-    .split('\n')
-    .map((line) => line.trim())
-    .filter((line) => line.length > 0);
-
-  for (const line of lines) {
-    const [id, multiplierRaw] = line.split(':').map((part) => part.trim());
-    const multiplier = Number(multiplierRaw);
-    if (!id || Number.isNaN(multiplier) || multiplier <= 0) {
-      return { value: {}, error: `Invalid multiplier line: "${line}" (expected id:number)` };
-    }
-    value[id] = multiplier;
-  }
-
-  return { value };
+  roleMultiplierEntries: MultiplierEntry[];
+  channelMultiplierEntries: MultiplierEntry[];
 }
 
 function toLocal(config: LevelingConfigDashboard): LocalLevelingValue {
   const { roleMultipliers, channelMultipliers, ...rest } = config;
   return {
     ...rest,
-    roleMultipliersText: toMultiplierText(roleMultipliers),
-    channelMultipliersText: toMultiplierText(channelMultipliers)
+    roleMultiplierEntries: mapToMultiplierEntries(roleMultipliers),
+    channelMultiplierEntries: mapToMultiplierEntries(channelMultipliers)
   };
 }
 
-async function saveLeveling(guildId: string, value: LocalLevelingValue): Promise<SettingsSaveResult> {
-  const roleMultipliers = fromMultiplierText(value.roleMultipliersText);
+async function saveLeveling(guildId: string, value: LocalLevelingValue, t: (key: string) => string): Promise<SettingsSaveResult> {
+  const roleMultipliers = multiplierEntriesToMap(value.roleMultiplierEntries);
   if (roleMultipliers.error) {
-    return { ok: false, error: roleMultipliers.error };
+    return { ok: false, error: t(`modulePages.leveling.errors.${roleMultipliers.error}`) };
   }
-  const channelMultipliers = fromMultiplierText(value.channelMultipliersText);
+  const channelMultipliers = multiplierEntriesToMap(value.channelMultiplierEntries);
   if (channelMultipliers.error) {
-    return { ok: false, error: channelMultipliers.error };
+    return { ok: false, error: t(`modulePages.leveling.errors.${channelMultipliers.error}`) };
   }
 
-  const { roleMultipliersText: _roleMultipliersText, channelMultipliersText: _channelMultipliersText, ...rest } = value;
+  const {
+    roleMultiplierEntries: _roleMultiplierEntries,
+    channelMultiplierEntries: _channelMultiplierEntries,
+    ...rest
+  } = value;
 
   const payload: LevelingConfigDashboard = {
     ...rest,
@@ -99,7 +84,7 @@ export function LevelingForm({ guildId, initialValue }: LevelingFormProps) {
   return (
     <SettingsForm<LocalLevelingValue>
       initialValue={toLocal(initialValue)}
-      onSave={(value) => saveLeveling(guildId, value)}
+      onSave={(value) => saveLeveling(guildId, value, t)}
     >
       {({ value, setValue }) => (
         <div className="space-y-6">
@@ -197,12 +182,11 @@ export function LevelingForm({ guildId, initialValue }: LevelingFormProps) {
                 <FieldAnchor id="field-leveling-role-multipliers">
                 <div className="space-y-2">
                   <Label>{t('modulePages.leveling.roleMultipliers')}</Label>
-                  <Textarea
-                    className="font-mono"
-                    rows={4}
-                    value={value.roleMultipliersText}
-                    onChange={(event) => setValue((prev) => ({ ...prev, roleMultipliersText: event.target.value }))}
-                    placeholder="123456789012345678:1.5"
+                  <DiscordMultiplierEditor
+                    guildId={guildId}
+                    kind="role"
+                    value={value.roleMultiplierEntries}
+                    onChange={(roleMultiplierEntries) => setValue((prev) => ({ ...prev, roleMultiplierEntries }))}
                   />
                   <p className="text-xs text-muted-foreground">{t('modulePages.leveling.multiplierHint')}</p>
                 </div>
@@ -210,12 +194,13 @@ export function LevelingForm({ guildId, initialValue }: LevelingFormProps) {
                 <FieldAnchor id="field-leveling-channel-multipliers">
                 <div className="space-y-2">
                   <Label>{t('modulePages.leveling.channelMultipliers')}</Label>
-                  <Textarea
-                    className="font-mono"
-                    rows={4}
-                    value={value.channelMultipliersText}
-                    onChange={(event) => setValue((prev) => ({ ...prev, channelMultipliersText: event.target.value }))}
-                    placeholder="123456789012345678:2"
+                  <DiscordMultiplierEditor
+                    guildId={guildId}
+                    kind="channel"
+                    value={value.channelMultiplierEntries}
+                    onChange={(channelMultiplierEntries) =>
+                      setValue((prev) => ({ ...prev, channelMultiplierEntries }))
+                    }
                   />
                   <p className="text-xs text-muted-foreground">{t('modulePages.leveling.multiplierHint')}</p>
                 </div>
@@ -243,9 +228,9 @@ export function LevelingForm({ guildId, initialValue }: LevelingFormProps) {
                       <SelectValue />
                     </SelectTrigger>
                     <SelectContent>
-                      <SelectItem value="CHANNEL">{t('modulePages.leveling.mode.CHANNEL')}</SelectItem>
-                      <SelectItem value="DM">{t('modulePages.leveling.mode.DM')}</SelectItem>
-                      <SelectItem value="OFF">{t('modulePages.leveling.mode.OFF')}</SelectItem>
+                      <SelectItem value="CHANNEL">{t('modulePages.leveling.modes.CHANNEL')}</SelectItem>
+                      <SelectItem value="DM">{t('modulePages.leveling.modes.DM')}</SelectItem>
+                      <SelectItem value="OFF">{t('modulePages.leveling.modes.OFF')}</SelectItem>
                     </SelectContent>
                   </Select>
                 </div>
diff --git a/apps/webui/src/components/modules/ticket-config-form.tsx b/apps/webui/src/components/modules/ticket-config-form.tsx
index c7beafd..caf574e 100644
--- a/apps/webui/src/components/modules/ticket-config-form.tsx
+++ b/apps/webui/src/components/modules/ticket-config-form.tsx
@@ -70,8 +70,8 @@ export function TicketConfigForm({ guildId, initialValue }: TicketConfigFormProp
                     <SelectValue />
                   </SelectTrigger>
                   <SelectContent>
-                    <SelectItem value="CHANNEL">{t('modulePages.tickets.mode.CHANNEL')}</SelectItem>
-                    <SelectItem value="THREAD">{t('modulePages.tickets.mode.THREAD')}</SelectItem>
+                    <SelectItem value="CHANNEL">{t('modulePages.tickets.modes.CHANNEL')}</SelectItem>
+                    <SelectItem value="THREAD">{t('modulePages.tickets.modes.THREAD')}</SelectItem>
                   </SelectContent>
                 </Select>
               </div>
diff --git a/apps/webui/src/components/ui/discord-multiplier-editor.tsx b/apps/webui/src/components/ui/discord-multiplier-editor.tsx
new file mode 100644
index 0000000..d841306
--- /dev/null
+++ b/apps/webui/src/components/ui/discord-multiplier-editor.tsx
@@ -0,0 +1,122 @@
+'use client';
+
+import { Plus, Trash2 } from 'lucide-react';
+import { useTranslations } from '@/components/locale-provider';
+import { Button } from '@/components/ui/button';
+import { DiscordChannelSelect } from '@/components/ui/discord-channel-select';
+import { DiscordRoleSelect } from '@/components/ui/discord-role-select';
+import { Input } from '@/components/ui/input';
+import { Label } from '@/components/ui/label';
+
+export interface MultiplierEntry {
+  clientKey: string;
+  id: string;
+  multiplier: number;
+}
+
+export function mapToMultiplierEntries(map: Record<string, number>): MultiplierEntry[] {
+  return Object.entries(map).map(([id, multiplier]) => ({
+    clientKey: id,
+    id,
+    multiplier
+  }));
+}
+
+export function multiplierEntriesToMap(
+  entries: MultiplierEntry[]
+): { value: Record<string, number>; error?: string } {
+  const value: Record<string, number> = {};
+
+  for (const entry of entries) {
+    if (!entry.id) {
+      return { value: {}, error: 'multiplierMissingId' };
+    }
+    if (!Number.isFinite(entry.multiplier) || entry.multiplier <= 0) {
+      return { value: {}, error: 'multiplierInvalid' };
+    }
+    if (value[entry.id] !== undefined) {
+      return { value: {}, error: 'multiplierDuplicate' };
+    }
+    value[entry.id] = entry.multiplier;
+  }
+
+  return { value };
+}
+
+interface DiscordMultiplierEditorProps {
+  guildId: string;
+  kind: 'role' | 'channel';
+  value: MultiplierEntry[];
+  onChange: (next: MultiplierEntry[]) => void;
+}
+
+export function DiscordMultiplierEditor({ guildId, kind, value, onChange }: DiscordMultiplierEditorProps) {
+  const t = useTranslations();
+
+  function updateEntry(clientKey: string, patch: Partial<Pick<MultiplierEntry, 'id' | 'multiplier'>>) {
+    onChange(value.map((entry) => (entry.clientKey === clientKey ? { ...entry, ...patch } : entry)));
+  }
+
+  return (
+    <div className="space-y-3">
+      {value.map((entry) => (
+        <div key={entry.clientKey} className="flex items-end gap-2">
+          <div className="min-w-0 flex-1 space-y-2">
+            <Label className="sr-only">
+              {kind === 'role' ? t('modulePages.leveling.roleMultipliers') : t('modulePages.leveling.channelMultipliers')}
+            </Label>
+            {kind === 'role' ? (
+              <DiscordRoleSelect
+                guildId={guildId}
+                value={entry.id}
+                onChange={(id) => updateEntry(entry.clientKey, { id })}
+              />
+            ) : (
+              <DiscordChannelSelect
+                guildId={guildId}
+                kinds={['text', 'voice']}
+                value={entry.id}
+                onChange={(id) => updateEntry(entry.clientKey, { id })}
+              />
+            )}
+          </div>
+          <div className="w-24 space-y-2">
+            <Label className="sr-only">{t('modulePages.leveling.multiplierValue')}</Label>
+            <Input
+              type="number"
+              min={0.1}
+              step={0.1}
+              value={entry.multiplier}
+              onChange={(event) =>
+                updateEntry(entry.clientKey, { multiplier: Number(event.target.value) || 0 })
+              }
+            />
+          </div>
+          <Button
+            type="button"
+            variant="ghost"
+            size="icon"
+            aria-label={t('common.remove')}
+            onClick={() => onChange(value.filter((item) => item.clientKey !== entry.clientKey))}
+          >
+            <Trash2 className="size-4" />
+          </Button>
+        </div>
+      ))}
+      <Button
+        type="button"
+        variant="outline"
+        size="sm"
+        onClick={() =>
+          onChange([
+            ...value,
+            { clientKey: `new-${kind}-${Date.now()}`, id: '', multiplier: 1.5 }
+          ])
+        }
+      >
+        <Plus className="size-4" />
+        {t('modulePages.leveling.addMultiplier')}
+      </Button>
+    </div>
+  );
+}
diff --git a/apps/webui/src/messages/de.json b/apps/webui/src/messages/de.json
index 2970244..6eefc8c 100644
--- a/apps/webui/src/messages/de.json
+++ b/apps/webui/src/messages/de.json
@@ -318,13 +318,22 @@
       "noXpRoles": "No-XP-Rollen",
       "roleMultipliers": "Rollen-Multiplikatoren",
       "channelMultipliers": "Kanal-Multiplikatoren",
-      "multiplierHint": "Ein Eintrag pro Zeile im Format ID:Multiplikator, z. B. 123456789012345678:1.5",
+      "multiplierHint": "Rolle bzw. Kanal wählen und Multiplikator setzen (z. B. 1.5).",
+      "multiplierValue": "Multiplikator",
+      "addMultiplier": "Multiplikator hinzufügen",
+      "errors": {
+        "multiplierMissingId": "Jeder Multiplikator braucht eine Rolle bzw. einen Kanal.",
+        "multiplierInvalid": "Multiplikatoren müssen eine positive Zahl sein.",
+        "multiplierDuplicate": "Jede Rolle bzw. jeder Kanal darf nur einmal vorkommen."
+      },
       "levelUpTitle": "Level-Up-Nachricht",
       "levelUpMode": "Modus",
-      "mode.CHANNEL": "Kanal",
-      "mode.DM": "Direktnachricht",
-      "mode.OFF": "Aus",
-      "levelUpChannelId": "Level-Up-Kanal-ID",
+      "modes": {
+        "CHANNEL": "Kanal",
+        "DM": "Direktnachricht",
+        "OFF": "Aus"
+      },
+      "levelUpChannelId": "Level-Up-Kanal",
       "levelUpMessage": "Nachrichtentext",
       "stackRewards": "Rollen-Belohnungen stapeln",
       "rankCardTitle": "Rang-Karte",
@@ -358,10 +367,12 @@
       "description": "Lege fest, wie Support-Tickets erstellt und verwaltet werden.",
       "enabledLabel": "Ticket-Modul aktiviert",
       "mode": "Ticket-Modus",
-      "mode.CHANNEL": "Privater Kanal",
-      "mode.THREAD": "Privater Thread",
+      "modes": {
+        "CHANNEL": "Privater Kanal",
+        "THREAD": "Privater Thread"
+      },
       "categoryId": "Ticket-Kategorie-ID",
-      "logChannelId": "Log-Kanal-ID",
+      "logChannelId": "Log-Kanal",
       "inactivityHours": "Automatisch schließen nach Inaktivität (Stunden)",
       "transcriptDm": "Transkript per DM an Ticket-Ersteller",
       "transcriptDmHint": "Sendet dem Nutzer nach Schließung ein Transkript per DM.",
diff --git a/apps/webui/src/messages/en.json b/apps/webui/src/messages/en.json
index afaff41..a4e24c1 100644
--- a/apps/webui/src/messages/en.json
+++ b/apps/webui/src/messages/en.json
@@ -318,13 +318,22 @@
       "noXpRoles": "No-XP roles",
       "roleMultipliers": "Role multipliers",
       "channelMultipliers": "Channel multipliers",
-      "multiplierHint": "One entry per line in the format id:multiplier, e.g. 123456789012345678:1.5",
+      "multiplierHint": "Pick a role or channel and set a multiplier (e.g. 1.5).",
+      "multiplierValue": "Multiplier",
+      "addMultiplier": "Add multiplier",
+      "errors": {
+        "multiplierMissingId": "Every multiplier needs a role or channel.",
+        "multiplierInvalid": "Multipliers must be a positive number.",
+        "multiplierDuplicate": "Each role or channel may only appear once."
+      },
       "levelUpTitle": "Level-up message",
       "levelUpMode": "Mode",
-      "mode.CHANNEL": "Channel",
-      "mode.DM": "Direct message",
-      "mode.OFF": "Off",
-      "levelUpChannelId": "Level-up channel ID",
+      "modes": {
+        "CHANNEL": "Channel",
+        "DM": "Direct message",
+        "OFF": "Off"
+      },
+      "levelUpChannelId": "Level-up channel",
       "levelUpMessage": "Message content",
       "stackRewards": "Stack role rewards",
       "rankCardTitle": "Rank card",
@@ -358,10 +367,12 @@
       "description": "Configure how support tickets are created and managed.",
       "enabledLabel": "Tickets module enabled",
       "mode": "Ticket mode",
-      "mode.CHANNEL": "Private channel",
-      "mode.THREAD": "Private thread",
+      "modes": {
+        "CHANNEL": "Private channel",
+        "THREAD": "Private thread"
+      },
       "categoryId": "Ticket category ID",
-      "logChannelId": "Log channel ID",
+      "logChannelId": "Log channel",
       "inactivityHours": "Auto-close after inactivity (hours)",
       "transcriptDm": "DM transcript to ticket creator",
       "transcriptDmHint": "Sends a transcript to the user via DM once their ticket is closed.",